test(SDK-553): add PolicyList integration tests#1414
Closed
krisxcrash wants to merge 2 commits intokw/feat/sdk-553-policy-list-functionalfrom
Closed
test(SDK-553): add PolicyList integration tests#1414krisxcrash wants to merge 2 commits intokw/feat/sdk-553-policy-list-functionalfrom
krisxcrash wants to merge 2 commits intokw/feat/sdk-553-policy-list-functionalfrom
Conversation
krisxcrash
requested review from
dmortal,
hukid,
jeffredodd and
serikjensen
as code owners
krisxcrash
force-pushed
the
kw/feat/sdk-553-policy-list-functional
branch
from
a4110ff to
8a68f32
Compare
krisxcrash
force-pushed
the
kw/test/sdk-553-policy-list-tests
branch
from
14f255b to
e816471
Compare
krisxcrash
force-pushed
the
kw/feat/sdk-553-policy-list-functional
branch
from
8a68f32 to
c4106ab
Compare
krisxcrash
force-pushed
the
kw/test/sdk-553-policy-list-tests
branch
from
e816471 to
d676401
Compare
Replace the stub PolicyList with a real implementation that fetches time off policies and active employees, computes enrolled display strings, and handles create/edit/finish-setup/delete actions via PolicyListPresentation with baseSubmitHandler error handling and query cache invalidation.
krisxcrash
force-pushed
the
kw/feat/sdk-553-policy-list-functional
branch
from
1146845 to
e6e7fd8
Compare
Cover rendering (policy names, enrolled counts, empty state), navigation events (create, edit, finish-setup), and delete flow (dialog open/close, deactivate API call, success alert) using MSW mocks.
krisxcrash
force-pushed
the
kw/test/sdk-553-policy-list-tests
branch
from
d676401 to
734c718
Compare
krisxcrash
force-pushed
the
kw/feat/sdk-553-policy-list-functional
branch
from
e6e7fd8 to
e2b0907
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PolicyListfunctional component using MSW API mocksTIME_OFF_CREATE_POLICY,TIME_OFF_VIEW_POLICY), and delete flow (dialog, deactivate API, success alert, cancel)Test plan